added ockam:// scheme association in app for linux and mac #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide-baldo
force-pushed
the
davide-baldo/url-scheme-using-tauri-alpha11
branch
3 times, most recently
from
428ffcc to
82c2366
Compare
davide-baldo
force-pushed
the
davide-baldo/url-scheme-using-tauri-alpha11
branch
4 times, most recently
from
d2eb502 to
b6c897b
Compare
davide-baldo
force-pushed
the
davide-baldo/url-scheme-using-tauri-alpha11
branch
11 times, most recently
from
ddd6282 to
5e75c4d
Compare
metaclips
requested changes
Sep 11, 2023
davide-baldo
force-pushed
the
davide-baldo/url-scheme-using-tauri-alpha11
branch
from
5e75c4d to
02d75e5
Compare
davide-baldo
force-pushed
the
davide-baldo/url-scheme-using-tauri-alpha11
branch
from
02d75e5 to
647fba5
Compare
metaclips
approved these changes
Sep 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on alpha11 upgrade branch.
Added support for both linux and mac for the
ockam://custom scheme.Since tauri doesn't handle linux url passing I've recovered work from previous pr.
Both
.desktopfile andpListrespectively for linux and mac, are now directly generated by tauri.Note that to apply a patch, tauri has been overridden to https://github.com/build-trust/tauri.git
In order to start
cargo tauri buildthe tauri-cli must be compiled and installed from the fork, for this reason the cli has been overridden in the build system. The docker build image wasn't changed because gradle build is deprecated and will be removed soon.